This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Refactor objectd: Move array capacity functions to rt/array/capacity.d #2647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinShil
commented
Jun 19, 2019
|
|
||
| // HACK: This is a lie. `_d_arraysetcapacity` is neither `nothrow` nor `pure`, but this lie is | ||
| // necessary for now to prevent breaking code. | ||
| private extern (C) size_t _d_arraysetcapacity(const TypeInfo ti, size_t newcapacity, void[]* arrptr) pure nothrow; |
Contributor
Author
There was a problem hiding this comment.
This important note was absent in object.d. I added it here for full transparency.
JinShil
commented
Jun 19, 2019
|
|
||
| // HACK: This is a lie. `_d_arrayshrinkfit` is not `nothrow`, but this lie is necessary | ||
| // for now to prevent breaking code. | ||
| private extern (C) void _d_arrayshrinkfit(const TypeInfo ti, void[] arr) nothrow; |
Contributor
Author
There was a problem hiding this comment.
This important note was absent in object.d. I added it here for full transparency.
jacob-carlborg
approved these changes
Jun 19, 2019
PetarKirov
approved these changes
Jun 19, 2019
This was referenced Aug 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #2644, #2643, and #2634